Skip to content

More RC updates#763

Closed
NickGeneva wants to merge 5 commits intoNVIDIA:mainfrom
NickGeneva:ngeneva/natten_remove_arch
Closed

More RC updates#763
NickGeneva wants to merge 5 commits intoNVIDIA:mainfrom
NickGeneva:ngeneva/natten_remove_arch

Conversation

@NickGeneva
Copy link
Collaborator

@NickGeneva NickGeneva commented Mar 18, 2026

Earth2Studio Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.
  • Assess and address Greptile feedback (AI code review bot for guidance; use discretion, addressing all feedback is not required).

Dependencies

NickGeneva and others added 5 commits March 18, 2026 07:19
@NickGeneva
Bump hatch version
29493d4
@NickGeneva
Bump version to 0.13.0-rc
c1f5246
@NickGeneva
RC TOML Fixes (NVIDIA#759)
e58bb54 
* Adding missing all
* Fixing test names
* Adding missing install steps for healda
@NickGeneva
Remove natten env
56ff60e
@NickGeneva
Changelog
7dfb8fd
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 18, 2026 •
edited
Loading

Greptile Summary

This PR prepares the 0.13.0 release ("More RC updates") by bumping internal version strings, pinning all example scripts to the upcoming @0.13.0 tag, updating installation documentation, adding serve and da-healda to the all extra, renaming test files for consistency, and updating the lock file.

Key observations:

  • Version inconsistency: earth2studio/__init__.py is set to 0.13.0rc0 while every other artifact updated in this PR (CHANGELOG, examples, docs, bug template, recipe template) already references the final 0.13.0. This means the @0.13.0 git tag the examples point to does not exist during the RC phase, and the __version__ attribute would not match what users are told to report.
  • Duplicate lock-file entries: Adding serve into the all extra caused httpx (pinned at ==0.28.1 from data and >=0.25.0 from serve) and hydra-core (>=1.3.0 from serve, >=1.3.2 from dlesym) to appear twice under extra == 'all' in uv.lock. This is cosmetically noisy and may confuse resolvers.
  • Removed ARCO test case: datetime.datetime(year=2024, month=1, day=1) was removed from test_arco_cache parametrization. No explanation is given; a brief comment would help reviewers understand whether this was a flaky test, a data-availability issue, or intentional scope reduction.

Confidence Score: 3/5
  • Largely safe release-prep housekeeping, but the version string mismatch between __init__.py (0.13.0rc0) and all other references (0.13.0) should be resolved before merging to avoid broken example installs and user confusion.
  • Most changes are straightforward version-string updates and test renames. The main concern is the __init__.py version being rc0 while all documentation and examples already target the final 0.13.0 tag — a gap that would make examples uninstallable during the RC window. The duplicate dependency entries in uv.lock are cosmetic but worth cleaning up.
  • earth2studio/__init__.py (version mismatch), uv.lock (duplicate specifier entries for httpx and hydra-core under all)

Important Files Changed
Filename Overview
earth2studio/init.py Version bumped from 0.13.0a0 to 0.13.0rc0, but all other references (CHANGELOG, examples, docs, bug report template) already use 0.13.0 (the final release version), creating an inconsistency.
CHANGELOG.md Version header updated from [0.13.0a0] to [0.13.0] with a release date of 2026-03-20. Empty Deprecated and Security sections removed.
pyproject.toml Adds serve and da-healda extras to the all aggregate extra, and bumps the minimum hatch version to >=1.16.5.
uv.lock Lock file updated to include serve/da-healda dependencies under the all extra. Contains duplicate specifier entries for httpx and hydra-core under extra == 'all'.
tox-smoke.ini Adds flash-attention build environment variables and replaces extras = all tox shorthand with explicit uv sync + uv sync --extra all commands before wheel install.
test/data/test_arco.py Removes datetime.datetime(year=2024, month=1, day=1) from the parametrize list for test_arco_cache, reducing test coverage for a recent date.
docs/userguide/about/install.md All installation instructions updated from @0.12.1 to @0.13.0, and pip steps for da-healda now pre-install hatchling and earth2grid.
.github/ISSUE_TEMPLATE/bug_report.yml Version placeholder updated from 0.12.1 to 0.13.0.

Comments Outside Diff (2)

  1. uv.lock, line 659-660 (link)

    P2 Duplicate conflicting httpx specifiers for all extra

    Two requires-dist entries now exist for httpx under extra == 'all' with incompatible constraints:

    { name = "httpx", marker = "extra == 'all'", specifier = "==0.28.1" },
{ name = "httpx", marker = "extra == 'all'", specifier = ">=0.25.0" },

    This happens because adding serve to the all extra (in pyproject.toml) causes both the data constraint (==0.28.1) and the serve constraint (>=0.25.0) to be flattened under all. The strict pin ==0.28.1 from data is the effective resolver outcome, but having both in the metadata is redundant and may confuse tooling. Similarly, hydra-core ends up with both >=1.3.0 (from serve) and >=1.3.2 (from dlesym) under all:

    { name = "hydra-core", marker = "extra == 'all'", specifier = ">=1.3.0" },
{ name = "hydra-core", marker = "extra == 'all'", specifier = ">=1.3.2" },

    These duplicates are generated from pyproject.toml; consider deduplicating the httpx constraint in pyproject.toml for the all extra to keep a single authoritative specifier.

  2. earth2studio/__init__.py, line 120 (link)

    P2 Version mismatch between package and all references

    The package version is set to 0.13.0rc0, but every other reference updated in this same PR — CHANGELOG, all 25+ example scripts, install docs, bug report template, and the recipe template — already uses 0.13.0 (the final release string). This creates two concrete problems:

    1. Non-existent git tag during RC: All example scripts are now pinned to @0.13.0. While the package is still tagged as rc0, the 0.13.0 git tag does not exist, so anyone running these examples during the RC will get a resolution failure.
    2. Bug report confusion: The bug report template instructs users to report version 0.13.0, but import earth2studio; print(earth2studio.__version__) will return 0.13.0rc0.

    If this branch is meant to be the final release, the version here should be changed to 0.13.0. If it is genuinely still an RC, the examples, CHANGELOG, and docs should reference the RC tag (e.g. @0.13.0rc0) or remain pinned to main until the final tag is cut.

Last reviewed commit: "Changelog"

@NickGeneva NickGeneva closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NickGeneva